Afni verbosity #2345
Afni verbosity #2345
Conversation
nipype/interfaces/afni/preprocess.py
Outdated
| @@ -438,6 +438,12 @@ class AllineateInputSpec(AFNICommandInputSpec): | |||
| traits.Enum(*_dirs), | |||
| argstr='-nwarp_fixdep%s', | |||
| desc='To fix non-linear warp dependency along directions.') | |||
| verb = traits.Bool( | |||
There was a problem hiding this comment.
Feel free to say no, but would this make more sense as "verbose" instead of "verb"? I think that'll make interfaces a little friendlier to new users, while experienced AFNI users would know "verb" means "verbose", so it shouldn't cause confusion.
There was a problem hiding this comment.
yes I agree, I was hesitating on this one. Is that OK if I change all the AFNI verb (even introduced before my changes) to verbose ?
There was a problem hiding this comment.
Hmm. No, that would require deprecating, because somebody depends on this behavior. If it's consistent with existing interfaces, verb seems fine.
nipype/interfaces/afni/preprocess.py
Outdated
| desc='Print out verbose progress reports.') | ||
| quiet = traits.Bool( | ||
| argstr='-quiet', | ||
| desc='Don\'t print out verbose progress reports.') |
There was a problem hiding this comment.
Preference: Use double-quotes instead of escaping apostrophes within single quotes.
| @@ -1377,6 +1380,9 @@ class MaskToolInputSpec(AFNICommandInputSpec): | |||
| 'or using the labels in {R,L,A,P,I,S}.', | |||
| argstr='-fill_dirs %s', | |||
| requires=['fill_holes']) | |||
| verbose = traits.Int( | |||
There was a problem hiding this comment.
Note that you have verbose in Copy. If it's okay to mix-and-match (i.e., there are some interfaces that already have verbose), I'd prefer that you use verbose for all new additions. If this would be the first interface with verbose, I'd say switch it to verb for consistency.
There was a problem hiding this comment.
Sorry I am not sure to follow. I added verbose to Allineate, Copy, MaskTool andTcat. These interfaces had no verbosity parameter before. I didn't touch the other ones which had already a verb or a verbose parameter as you told me.
There was a problem hiding this comment.
Sorry, I think I wrote this just as you made those changes. I wasn't sure if you were going to keep it at verb, but the changes you made look good. You can safely ignore that last message. (Also this one.)
|
Looks good. Happy to merge when tests pass. |
add AFNI verbosity options when available