TST+FIX: do not save empty tar.gz file + use fastest gzip compression #2290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Previously, an empty tar.gz file was created on containers 1-3 to avoid errors when persisting to workspace. Container 0 saves the Docker images to tar.gz, but the empty tar.gz file would sometimes overwrite the tar.gz with the Docker images. Consequently, the deploy step would try to load Docker images from an empty tar.gz file and would fail. - To avoid errors on `persist_to_workspace`, save docker/* instead of docker/nipype-base-latest-py36-py27.tar.gz.
kaczmarj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Actually) Fixes breaking deploy step in CircleCI.
Changes proposed in this pull request
tar.gzfile in container 1-3. The empty files overwrote thetar.gzfile of Docker images, causingdocker loadto fail./tmp/docker/*instead of/tmp/docker/nipype-base-latest-py36-py27.tar.gz. This will save the tarball of Docker images in container 0 and will not fail on containers 1-3.gzipcompression. Turns out this was not the issue.Tests of this PR on my fork
gzip -6 ...gzip -1 ...Fastest
gzipproduces a 5.1 GB file in 9:30, andgzip -6produces a 4.7 GB file in 16:04. Fastestgzipcompression results in a net decrease in test/deploy time.