Skip to content

fix: testing for non-developer installation #2280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 15, 2017
Merged

Conversation

mgxd
Copy link
Member

@mgxd mgxd commented Nov 13, 2017

Addon to #2252 , fixes #2108 .

Changes proposed in this pull request

  • moves testing config files insides nipype directory and includes them during installation
  • minor fixes to included test data that was incompatible with setuptools 20.7.0 - Ubuntu 16.04 default

should allow testing through nipype.test() again

mgxd and others added 3 commits November 13, 2017 13:29
@codecov-io
Copy link

Codecov Report

Merging #2280 into master will decrease coverage by 5.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2280      +/-   ##
==========================================
- Coverage   72.52%   67.49%   -5.04%     
==========================================
  Files        1188     1189       +1     
  Lines       59143    59151       +8     
  Branches     8510     8510              
==========================================
- Hits        42892    39922    -2970     
- Misses      14866    18153    +3287     
+ Partials     1385     1076     -309
Flag Coverage Δ
#smoketests 67.49% <100%> (-5.04%) ⬇️
#unittests 64.97% <100%> (-5.17%) ⬇️
Impacted Files Coverage Δ
nipype/conftest.py 100% <100%> (ø)
nipype/workflows/graph/__init__.py 0% <0%> (-100%) ⬇️
nipype/workflows/fmri/spm/tests/__init__.py 0% <0%> (-100%) ⬇️
nipype/interfaces/minc/testdata.py 0% <0%> (-100%) ⬇️
nipype/sphinxext/__init__.py 0% <0%> (-100%) ⬇️
...pype/workflows/dmri/camino/connectivity_mapping.py 7.51% <0%> (-92.49%) ⬇️
...pype/workflows/dmri/mrtrix/connectivity_mapping.py 7.76% <0%> (-92.24%) ⬇️
nipype/workflows/dmri/camino/diffusion.py 11.11% <0%> (-88.89%) ⬇️
nipype/workflows/dmri/mrtrix/diffusion.py 6.32% <0%> (-87.35%) ⬇️
nipype/workflows/smri/freesurfer/ba_maps.py 11.11% <0%> (-79.17%) ⬇️
... and 84 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68e8ef0...4a6351b. Read the comment docs.

@mgxd mgxd requested a review from satra November 14, 2017 16:25
@satra
Copy link
Member

satra commented Nov 15, 2017

merging this but @djarecka - was looking for an option via nipype.test.

@satra satra merged commit c4a249a into nipy:master Nov 15, 2017
@djarecka
Copy link
Collaborator

djarecka commented Nov 15, 2017

@satra yes, I started looking and wasn't sure if we changed the concept. should I still work on it or we will use this pr?

@mgxd mgxd deleted the fix/pytest branch November 15, 2017 15:47
@mgxd mgxd removed the needs-review label Nov 15, 2017
@djarecka
Copy link
Collaborator

@mgxd : I misunderstood @satra , I don't work on nipype.test anymore, we agreed that moving pytest files is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation error
4 participants