[REF] Fix use of logging module in utils, algorithms and interfaces. #2276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix logging formatting in ants, cmtk, elastic, freesurfer, fsl, mrtrix,
mrtrix3, nilearn, and spm interfaces. Okay, it was mostly in cmtk, io,
and mrtrix.
- In nipype/interfaces/io.py logging is imported multiple times, and
iflogger is redefined a couple of times. Not sure if that’s the right
way to go.
- Is this okay:
- `iflogger.debug('saving inputs {}', inputs)`
(nipype/interfaces/base.py#L1210)
- Also caught a couple of things in nipype/interfaces/cmtk/nx.py.
Namely a couple of unused variables and at one point redefining `file`.
Codecov Report
@@ Coverage Diff @@
## master #2276 +/- ##
=======================================
Coverage 72.52% 72.52%
=======================================
Files 1188 1188
Lines 59134 59134
Branches 8506 8506
=======================================
Hits 42889 42889
Misses 14859 14859
Partials 1386 1386
Continue to review full report at Codecov.
|
|
@tsalo - there is one conflict due to a merge? could you please resolve and update this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #1242.
Changes proposed in this pull request
I went through
nipype.utils,nipype.algorithms, andnipype.interfaces, fixing the logging calls where I found them.