Skip to content

CI: Add pip install --pre entry to Travis #2197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2017
Merged

Conversation

effigies
Copy link
Member

This gives our dependencies a chance to break a Travis build before breaking everything downstream. I would treat failures of --pre builds as non-blocking for most PRs.

@codecov-io
Copy link

codecov-io commented Sep 24, 2017

Codecov Report

Merging #2197 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2197      +/-   ##
==========================================
- Coverage   72.22%   72.21%   -0.01%     
==========================================
  Files        1171     1171              
  Lines       58620    58620              
  Branches     8434     8434              
==========================================
- Hits        42339    42335       -4     
- Misses      14921    14924       +3     
- Partials     1360     1361       +1
Flag Coverage Δ
#smoketests 72.21% <ø> (-0.01%) ⬇️
#unittests 69.88% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
nipype/interfaces/base.py 82.94% <0%> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a8318f...3fa5c5c. Read the comment docs.

@satra
Copy link
Member

satra commented Sep 24, 2017

we should figure out a way to do this such that it's not a failure when something breaks here. also we should also do this on circle.

@effigies
Copy link
Member Author

Is the concern PRs showing failure when there is none? Or master showing failure?

@satra
Copy link
Member

satra commented Sep 24, 2017

@effigies - both.

@effigies
Copy link
Member Author

I guess causing a minor disruption before it becomes a major one seems like a feature, to me. I worry that if it's too unobtrusive, it will go unobserved, especially since it's going to be a pretty rare event.

I suppose we could do something where we check for failure, shoot an email, and return success so Travis stays green, though the failure mode for that could get pretty annoying to whoever has the unfortunate inbox.

As to Circle, are there any Python dependencies that only get exercised in Circle?

@satra
Copy link
Member

satra commented Sep 25, 2017

@effigies - alright let's go with this for now and revisit when things break.

@satra satra merged commit 9b857fa into nipy:master Sep 25, 2017
@satra
Copy link
Member

satra commented Sep 25, 2017

just a quick note that the flag only works when there is a pre-release on pypi.

@effigies effigies deleted the ci/travis_pre branch October 5, 2017 20:33
@satra satra added this to the 0.14.0 milestone Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants