Skip to content

ref: isolate function handling from __future__ imports #2150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 27, 2017

Conversation

mgxd
Copy link
Member

@mgxd mgxd commented Aug 15, 2017

Re-attempt after #2148

@mgxd mgxd requested a review from satra August 15, 2017 01:35
@codecov-io
Copy link

codecov-io commented Aug 15, 2017

Codecov Report

Merging #2150 into master will increase coverage by <.01%.
The diff coverage is 90.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2150      +/-   ##
==========================================
+ Coverage   72.32%   72.32%   +<.01%     
==========================================
  Files        1183     1185       +2     
  Lines       59008    59030      +22     
  Branches     8490     8490              
==========================================
+ Hits        42677    42694      +17     
- Misses      14947    14952       +5     
  Partials     1384     1384
Flag Coverage Δ
#smoketests 72.32% <90.16%> (ø) ⬆️
#unittests 69.9% <90.16%> (ø) ⬆️
Impacted Files Coverage Δ
nipype/utils/misc.py 74.1% <100%> (-4.09%) ⬇️
nipype/utils/tests/test_misc.py 100% <100%> (ø) ⬆️
nipype/utils/functions.py 100% <100%> (ø)
nipype/interfaces/utility/wrappers.py 85.18% <100%> (ø) ⬆️
nipype/pipeline/engine/workflows.py 78.82% <100%> (+0.03%) ⬆️
nipype/pipeline/engine/utils.py 79.45% <66.66%> (+0.02%) ⬆️
nipype/utils/tests/test_functions.py 82.75% <82.75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37c9db6...f709804. Read the comment docs.

@satra
Copy link
Member

satra commented Aug 24, 2017

@mgxd - can you make sure master is merged into this.

@mgxd
Copy link
Member Author

mgxd commented Aug 25, 2017

Yes, it is. Do you remember what error arose after merging this previously? If so, I could add a test for that.

@mgxd
Copy link
Member Author

mgxd commented Sep 12, 2017

@satra pinging this again

@mgxd
Copy link
Member Author

mgxd commented Oct 18, 2017

@satra let's try to get this in for 0.14

@satra
Copy link
Member

satra commented Oct 18, 2017

@mgxd - can you create a milestone for 0.14, and add any issues that should be resolved for 0.14.

@mgxd mgxd added this to the 0.14.0 milestone Oct 18, 2017
@mgxd
Copy link
Member Author

mgxd commented Oct 27, 2017

@satra tests are passing - let's give it a shot

@satra satra merged commit 1a74013 into nipy:master Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants