Skip to content

FIX: Set prov==1.5.0 dependency #2137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2017
Merged

FIX: Set prov==1.5.0 dependency #2137

merged 1 commit into from
Aug 2, 2017

Conversation

effigies
Copy link
Member

@effigies effigies commented Aug 1, 2017

This PR explores the issues with the currently failing builds.

Currently checking whether the prov 1.5.1 release is the issue.

@codecov-io
Copy link

Codecov Report

Merging #2137 into master will increase coverage by 1.84%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2137      +/-   ##
==========================================
+ Coverage   70.33%   72.17%   +1.84%     
==========================================
  Files        1153     1157       +4     
  Lines       57584    57970     +386     
  Branches     8327     8327              
==========================================
+ Hits        40501    41842    +1341     
+ Misses      15596    14808     -788     
+ Partials     1487     1320     -167
Flag Coverage Δ
#smoketests 72.17% <100%> (+1.84%) ⬆️
#unittests 69.82% <100%> (ø) ⬆️
Impacted Files Coverage Δ
nipype/info.py 84.37% <100%> (ø) ⬆️
examples/fmri_spm_dartel.py 85.18% <0%> (ø)
examples/fmri_fsl_reuse.py 75.67% <0%> (ø)
examples/fmri_spm_nested.py 86.44% <0%> (ø)
examples/fmri_fsl_feeds.py 96.61% <0%> (ø)
nipype/interfaces/freesurfer/preprocess.py 64.84% <0%> (+0.19%) ⬆️
nipype/interfaces/base.py 83.25% <0%> (+0.81%) ⬆️
nipype/interfaces/utility/base.py 91.01% <0%> (+1.12%) ⬆️
nipype/interfaces/fsl/maths.py 99.42% <0%> (+1.15%) ⬆️
nipype/pipeline/engine/nodes.py 84.88% <0%> (+1.52%) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b0686d...9915615. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Aug 1, 2017

Codecov Report

Merging #2137 into master will increase coverage by 1.84%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2137      +/-   ##
==========================================
+ Coverage   70.33%   72.17%   +1.84%     
==========================================
  Files        1153     1157       +4     
  Lines       57584    57970     +386     
  Branches     8327     8327              
==========================================
+ Hits        40501    41842    +1341     
+ Misses      15596    14808     -788     
+ Partials     1487     1320     -167
Flag Coverage Δ
#smoketests 72.17% <100%> (+1.84%) ⬆️
#unittests 69.82% <100%> (ø) ⬆️
Impacted Files Coverage Δ
nipype/info.py 84.37% <100%> (ø) ⬆️
examples/fmri_spm_dartel.py 85.18% <0%> (ø)
examples/fmri_fsl_reuse.py 75.67% <0%> (ø)
examples/fmri_spm_nested.py 86.44% <0%> (ø)
examples/fmri_fsl_feeds.py 96.61% <0%> (ø)
nipype/interfaces/freesurfer/preprocess.py 64.84% <0%> (+0.19%) ⬆️
nipype/interfaces/base.py 83.25% <0%> (+0.81%) ⬆️
nipype/interfaces/utility/base.py 91.01% <0%> (+1.12%) ⬆️
nipype/interfaces/fsl/maths.py 99.42% <0%> (+1.15%) ⬆️
nipype/pipeline/engine/nodes.py 84.88% <0%> (+1.52%) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b0686d...9915615. Read the comment docs.

@effigies
Copy link
Member Author

effigies commented Aug 1, 2017

prov 1.5.1 seems to be the issue.

@satra do we want to go ahead and merge this for now, and then start a new branch for relaxing the constraint and fixing the underlying issues?

@effigies effigies changed the title [WIP] FIX CircleCI build FIX: Set prov==1.5.0 Aug 2, 2017
@effigies effigies changed the title FIX: Set prov==1.5.0 FIX: Set prov==1.5.0 dependency Aug 2, 2017
@satra satra merged commit d9b183b into nipy:master Aug 2, 2017
@effigies effigies mentioned this pull request Aug 8, 2017
@effigies effigies deleted the fix/prov_pin branch August 8, 2017 17:11
@satra satra added this to the 0.14.0 milestone Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants