Skip to content

TEST: Do not modify SUBJECTS_DIR contents #2133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2017
Merged

Conversation

effigies
Copy link
Member

Fixes #2131.

Changes proposed in this pull request

  • Do not run MRIsExpand interface, to avoid touching $SUBJECTS_DIR/fsaverage/surf.

Loses the verification that the command line is untouched by running. We could restore it by making a copy of the fsaverage directory instead, if it seems worth it.

@satra
Copy link
Member

satra commented Sep 11, 2017

@effigies - could this be merged with master?

@codecov-io
Copy link

codecov-io commented Sep 12, 2017

Codecov Report

Merging #2133 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2133      +/-   ##
==========================================
- Coverage   72.28%   72.28%   -0.01%     
==========================================
  Files        1171     1171              
  Lines       58622    58619       -3     
  Branches     8433     8433              
==========================================
- Hits        42377    42374       -3     
  Misses      14887    14887              
  Partials     1358     1358
Flag Coverage Δ
#smoketests 72.28% <100%> (-0.01%) ⬇️
#unittests 69.95% <100%> (-0.01%) ⬇️
Impacted Files Coverage Δ
nipype/interfaces/freesurfer/tests/test_utils.py 96.77% <100%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61265fe...98f422e. Read the comment docs.

@satra satra merged commit 41d831d into nipy:master Sep 24, 2017
@effigies effigies deleted the test/no_touch branch October 5, 2017 20:33
@satra satra added this to the 0.14.0 milestone Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants