Skip to content

ENH: Only write FLIRT log if not previously written #2069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 8, 2017

Conversation

effigies
Copy link
Member

@effigies effigies commented Jun 6, 2017

Changes proposed in this pull request

  • Add FLIRT._log_written flag to indicate whether to write the log. This prevents multiple calls to aggregate_outputs from cluttering the log.
  • Some additional logic/style fixes in _parse_inputs while I was there.
    • Don't overwrite a pre-existing skip list
    • Take advantage of undefined traits evaluating False

@codecov-io
Copy link

codecov-io commented Jun 6, 2017

Codecov Report

Merging #2069 into master will increase coverage by <.01%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2069      +/-   ##
==========================================
+ Coverage   72.16%   72.17%   +<.01%     
==========================================
  Files        1137     1137              
  Lines       57194    57195       +1     
  Branches     8194     8193       -1     
==========================================
+ Hits        41276    41279       +3     
+ Misses      14629    14627       -2     
  Partials     1289     1289
Flag Coverage Δ
#smoketests 72.17% <77.77%> (ø) ⬆️
#unittests 69.78% <44.44%> (ø) ⬆️
Impacted Files Coverage Δ
nipype/interfaces/fsl/preprocess.py 82.6% <77.77%> (+0.02%) ⬆️
nipype/interfaces/base.py 83.99% <0%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a63c52d...6b08c27. Read the comment docs.

@satra satra merged commit 0b3a116 into nipy:master Jun 8, 2017
@effigies effigies deleted the enh/single_flirt_log branch October 5, 2017 20:28
@satra satra added this to the 0.14.0 milestone Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants