-
Notifications
You must be signed in to change notification settings - Fork 533
[FIX] CircleCI tests - error codes are not propagated #1858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The former structure of the tests.sh file in which all the tests are called did not exit with error if one of the test commands errored, since the last exit code was from codecov, and no exit code tracking or propagation was done. This PR fixes that issue. Additionally, the scripts related to CircleCI have been split up into a new .circle/ folder.
@chrisfilo I have some concerns with the collection of coverage results. Looking at the artifacts, it seems like only the node 0 is generating coverage xmls from the workflows. My question is: are the rest of nodes not supposed to generate coverage results? Other than that (and it could be fixed in another PR since we probably want this to be merged ASAP), this is ready to merge in. |
Codecov Report
@@ Coverage Diff @@
## master #1858 +/- ##
==========================================
+ Coverage 73.04% 73.11% +0.07%
==========================================
Files 1064 1064
Lines 53366 53370 +4
==========================================
+ Hits 38980 39023 +43
+ Misses 14386 14347 -39
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1858 +/- ##
==========================================
+ Coverage 73.04% 73.11% +0.07%
==========================================
Files 1064 1064
Lines 53366 53370 +4
==========================================
+ Hits 38980 39023 +43
+ Misses 14386 14347 -39
Continue to review full report at Codecov.
|
Since unittests are only run on node 0 it is the only one generating coverage XML files. Other nodes run smoke tests and generate other XML files (which from what I can see are also uploaded). |
@chrisfilo shouldn't this line at the end of the build output of node 2 generate an xml file?:
Apparently that is not happening now... |
The former structure of the tests.sh file in which all the tests are called
did not exit with error if one of the test commands errored, since the
last exit code was from codecov, and no exit code tracking or propagation
was done.
This PR fixes that issue. Additionally, the scripts related to CircleCI
have been split up into a new .circle/ folder.