Skip to content

[FIX] CircleCI tests - error codes are not propagated #1858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 4, 2017

Conversation

oesteban
Copy link
Contributor

@oesteban oesteban commented Mar 2, 2017

The former structure of the tests.sh file in which all the tests are called
did not exit with error if one of the test commands errored, since the
last exit code was from codecov, and no exit code tracking or propagation
was done.

This PR fixes that issue. Additionally, the scripts related to CircleCI
have been split up into a new .circle/ folder.

oesteban added 5 commits March 2, 2017 09:59
The former structure of the tests.sh file in which all the tests are called
did not exit with error if one of the test commands errored, since the
last exit code was from codecov, and no exit code tracking or propagation
was done.

This PR fixes that issue. Additionally, the scripts related to CircleCI
have been split up into a new .circle/ folder.
@oesteban
Copy link
Contributor Author

oesteban commented Mar 4, 2017

@chrisfilo I have some concerns with the collection of coverage results. Looking at the artifacts, it seems like only the node 0 is generating coverage xmls from the workflows.

My question is: are the rest of nodes not supposed to generate coverage results?

Other than that (and it could be fixed in another PR since we probably want this to be merged ASAP), this is ready to merge in.

@codecov-io
Copy link

Codecov Report

Merging #1858 into master will increase coverage by 0.07%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master    #1858      +/-   ##
==========================================
+ Coverage   73.04%   73.11%   +0.07%     
==========================================
  Files        1064     1064              
  Lines       53366    53370       +4     
==========================================
+ Hits        38980    39023      +43     
+ Misses      14386    14347      -39
Flag Coverage Δ
#unittests 73.11% <75%> (+0.07%)
Impacted Files Coverage Δ
...ype/interfaces/freesurfer/tests/test_preprocess.py 96.22% <75%> (+4.38%)
nipype/utils/filemanip.py 87.17% <0%> (+0.36%)
nipype/interfaces/tests/test_runtime_profiler.py 44.13% <0%> (+0.55%)
nipype/interfaces/utility/wrappers.py 89.79% <0%> (+1.02%)
nipype/pipeline/plugins/multiproc.py 77.09% <0%> (+1.67%)
nipype/utils/tests/test_cmd.py 98.55% <0%> (+2.89%)
nipype/init.py 68.75% <0%> (+3.12%)
nipype/utils/tests/test_filemanip.py 93.21% <0%> (+12.66%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e450340...26dfd79. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Mar 4, 2017

Codecov Report

Merging #1858 into master will increase coverage by 0.07%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master    #1858      +/-   ##
==========================================
+ Coverage   73.04%   73.11%   +0.07%     
==========================================
  Files        1064     1064              
  Lines       53366    53370       +4     
==========================================
+ Hits        38980    39023      +43     
+ Misses      14386    14347      -39
Flag Coverage Δ
#unittests 73.11% <75%> (+0.07%)
Impacted Files Coverage Δ
...ype/interfaces/freesurfer/tests/test_preprocess.py 96.22% <75%> (+4.38%)
nipype/utils/filemanip.py 87.17% <0%> (+0.36%)
nipype/interfaces/tests/test_runtime_profiler.py 44.13% <0%> (+0.55%)
nipype/interfaces/utility/wrappers.py 89.79% <0%> (+1.02%)
nipype/pipeline/plugins/multiproc.py 77.09% <0%> (+1.67%)
nipype/utils/tests/test_cmd.py 98.55% <0%> (+2.89%)
nipype/init.py 68.75% <0%> (+3.12%)
nipype/utils/tests/test_filemanip.py 93.21% <0%> (+12.66%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e450340...26dfd79. Read the comment docs.

@chrisgorgo
Copy link
Member

Since unittests are only run on node 0 it is the only one generating coverage XML files. Other nodes run smoke tests and generate other XML files (which from what I can see are also uploaded).

@chrisgorgo chrisgorgo merged commit dd4f101 into nipy:master Mar 4, 2017
@oesteban
Copy link
Contributor Author

oesteban commented Mar 4, 2017

@chrisfilo shouldn't this line at the end of the build output of node 2 generate an xml file?:

coverage xml -o /scratch/smoketest_fmri_spm_nested_MultiProc__root_examples__l2pipeline.xml

Apparently that is not happening now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants