Skip to content

Fix sge #1810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 16, 2017
Merged

Fix sge #1810

merged 2 commits into from
Feb 16, 2017

Conversation

bpinsard
Copy link
Contributor

fix QJobInfo.repr crashing silently in QstatSubstitute._parse_qstat_job_list
because _job_slots is not an int (not cast to int or "unknown")

@codecov-io
Copy link

codecov-io commented Feb 14, 2017

Codecov Report

Merging #1810 into master will decrease coverage by -0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1810      +/-   ##
==========================================
- Coverage   69.82%   69.82%   -0.01%     
==========================================
  Files        1047     1047              
  Lines       52133    52133              
  Branches     7669     7669              
==========================================
- Hits        36403    36402       -1     
- Misses      14142    14143       +1     
  Partials     1588     1588
Flag Coverage Δ
#unittests 69.82% <ø> (-0.01%)
Impacted Files Coverage Δ
nipype/pipeline/plugins/sge.py 17.74% <ø> (ø)
nipype/pipeline/plugins/tests/test_multiproc.py 72.32% <ø> (-3.15%)
nipype/pipeline/plugins/multiproc.py 77.65% <ø> (+2.23%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5ed4d6...c649f0e. Read the comment docs.

@satra satra merged commit 1a4e7ea into nipy:master Feb 16, 2017
@bpinsard bpinsard deleted the fix_sge branch July 7, 2017 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants