Skip to content

Update dti.py #1653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2018
Merged

Update dti.py #1653

merged 1 commit into from
Jan 9, 2018

Conversation

forwho
Copy link
Contributor

@forwho forwho commented Sep 20, 2016

Fix the bug of diffusion_toolkit interface.the attribute random_seed defined in the DTITrackerInputSpec Class has some mistake,the defination should be
random_seed = traits.Int(desc="use random location in a voxel instead of the center of the voxel to seed. can also define number of seed per voxel. default is 1", argstr="-rseed %d")
not
random_seed = traits.Int(desc="use random location in a voxel instead of the center of the voxel to seed. can also define number of seed per voxel. default is 1", argstr="-rseed")

fix the bug of diffusion_toolkit interfaces
Copy link
Contributor

@blakedewey blakedewey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your tests are failing because your change in the input does not match the auto test for this interface. Please run make check-before-commit to update the test file for this interface and commit the changed test file.

@mgxd
Copy link
Member

mgxd commented May 1, 2017

@forwho can you merge with current master? and run make specs?

@djarecka
Copy link
Collaborator

@forwho - thanks for the PR, it needs to be merge with current master and auto tests should be updated. Do you need help with it?

@djarecka
Copy link
Collaborator

@forwho - please let us know if you're planning to work on this PR, otherwise I'll try to review and finish.

@djarecka djarecka self-assigned this Jan 9, 2018
@oesteban oesteban merged commit 307fdde into nipy:master Jan 9, 2018
oesteban added a commit that referenced this pull request Jan 9, 2018
@forwho forwho deleted the DiffusionToolkit_fix branch January 17, 2018 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants