Skip to content

FIX: undefined variable #1633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 19, 2016
Merged

FIX: undefined variable #1633

merged 2 commits into from
Sep 19, 2016

Conversation

mgxd
Copy link
Member

@mgxd mgxd commented Sep 14, 2016

addresses #1632

@mgxd mgxd added the bug label Sep 14, 2016
@codecov-io
Copy link

codecov-io commented Sep 14, 2016

Current coverage is 70.88% (diff: 0.00%)

Merging #1633 into master will decrease coverage by 0.01%

@@             master      #1633   diff @@
==========================================
  Files          1019       1019          
  Lines         51277      51278     +1   
  Methods           0          0          
  Messages          0          0          
  Branches       7265       7265          
==========================================
- Hits          36351      36346     -5   
- Misses        13840      13851    +11   
+ Partials       1086       1081     -5   

Powered by Codecov. Last update 0bb9561...2ed433d

@mgxd
Copy link
Member Author

mgxd commented Sep 15, 2016

I'm stuck on codecov/patch - what am I missing?

Copy link
Contributor

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should not worry about the codecov/patch check, we are still figuring out how to integrate codecov correctly.

@mgxd
Copy link
Member Author

mgxd commented Sep 19, 2016

@satra @chrisfilo @oesteban ready to merge?

@satra
Copy link
Member

satra commented Sep 19, 2016

testing this would require a real test on real data. this needs to happen across all interfaces.

@mgxd - could you add real testing to the test issue ( #1648 ) that @shoshber created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants