Skip to content

Dcm2nii #1424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 18, 2016
Merged

Dcm2nii #1424

merged 7 commits into from
Apr 18, 2016

Conversation

akeshavan
Copy link
Collaborator

  • the dcm2nii interface was returning a list of 2 identical files.
  • if dcm2nii gave a warning, it was taken as a filename (which doesn't exist)

This had to do with how stdout was parsed. My version of dcm2nii wrote the filename in stdout twice, so the interface picked it up twice. Also, warnings have the arrow ("->") which threw things off.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 72.535% when pulling e5674fe on akeshavan:dcm2nii into 4b392d5 on nipy:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.005%) to 72.533% when pulling 2090493 on akeshavan:dcm2nii into 4b392d5 on nipy:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.005%) to 72.533% when pulling dee2e58 on akeshavan:dcm2nii into 4b392d5 on nipy:master.

@satra
Copy link
Member

satra commented Apr 16, 2016

@akeshavan - check circle ci tests?

@satra satra merged commit 77b1cb9 into nipy:master Apr 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants