Fix/vol2surf #1078
Fix/vol2surf #1078
Conversation
| surf_reg = traits.Bool(argstr="--surfreg", requires=["target_subject"], | ||
| desc="use surface registration to target subject") | ||
| surf_reg = traits.String(argstr="--surfreg %s", requires=["target_subject"], | ||
| desc="registration surface to target subject (default sphere.reg)") |
There was a problem hiding this comment.
in such a case, you may want to explicitly set the default value of the traits to sphere.reg
surf_reg = traits.String('sphere.reg', ..., usedefault=True)
|
we considered that, too, but thought rather to mimic freesurfer's original behavior: |
|
@SaOligg88 - for this to work we need to ensure versioning is in place (and it's only somewhat in place). say for example, freesurfer changes the default from sphere.reg to fancynew.reg. then from a nipype perspective it won't rerun a node because it doesn't know that some default has changed, and from a reproducibility perspective running an older script may not generate the same output because it's actually being called with different parameters. so i would suggest that we start moving towards encoding the defaults where we can. we will over time start moving the specification to the underlying software themselves (e.g., like slicer), such that these things are automatically picked up together with versioning. |
|
@soligschlager are you still working on this PR? Do you need help? |
|
@soligschlager - please let us know if you're planning to work on this PR, otherwise I'll try to review and finish. |
|
Hi there, no, unfortunately I'm not. Thanks for checking. |
|
@soligschlager - thank you for answering. I will review and check what is still missing. |
Close nipy#1078 as this PR supercedes that one
surf_reg option was broken.
We ran the tests, but weren't sure whether that went ok