TEST: Use more constrained mock when testing optpkg #983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing mock raised errors on any import except a whitelisted unittest. Because pytest monkeypatches the Python interpreter and then performs imports within the patched functions, this breaks in Pytest 3.10. Move to an import that blacklists the specific module we're testing.
Codecov Report
@@ Coverage Diff @@
## maint/3.2.x #983 +/- ##
===============================================
- Coverage 91.89% 91.85% -0.04%
===============================================
Files 101 101
Lines 12550 12550
Branches 2209 2209
===============================================
- Hits 11533 11528 -5
- Misses 680 683 +3
- Partials 337 339 +2
Continue to review full report at Codecov.
|
|
@yarikoptic Can you verify this resolves the error for you as well? |
|
YES -- it resolved it, sorry forgot to follow up. I have uploaded fresh nibabel to debian and neurodebian with this PR patch. https://salsa.debian.org/med-team/nibabel/-/blob/master/debian/patches/983.patch |
|
Thanks. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing mock raised errors on any import except a whitelisted unittest. Because old versions of pytest monkeypatched the Python interpreter and then performed imports within the patched functions, this breaks in Pytest 3.10. Move to an import that blacklists the specific module we're testing, which should be more resilient to test runner interference.
Fixes #982.