Skip to content

DOC: Remove to_filename from Getting started #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 24, 2020
Merged

DOC: Remove to_filename from Getting started #946

merged 4 commits into from
Aug 24, 2020

Conversation

fepegar
Copy link
Contributor

@fepegar fepegar commented Aug 19, 2020

As suggested by @matthew-brett in #945.

@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

Merging #946 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #946   +/-   ##
=======================================
  Coverage   91.84%   91.84%           
=======================================
  Files          97       97           
  Lines       12427    12427           
  Branches     2191     2191           
=======================================
  Hits        11414    11414           
  Misses        678      678           
  Partials      335      335           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 516434c...a48054e. Read the comment docs.

@matthew-brett
Copy link
Member

Looks right to me! @effigies - what do you think?

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, LGTM. One thing we can do is to just skip the save with a doctest flag, rather than explaining in text, but feel free to ignore if being more explicit feels right.

fepegar and others added 2 commits August 24, 2020 15:09
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
@fepegar
Copy link
Contributor Author

fepegar commented Aug 24, 2020

I like that. I didn't know what "We won't do it here" meant anyway.

@matthew-brett
Copy link
Member

Thanks @fepegar for following up with this, and @effigies for the review.

@matthew-brett matthew-brett merged commit e65b865 into nipy:master Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants