Skip to content

FIX: Detect IndexedGzipFile as compressed file type #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pauldmccarthy
Copy link
Contributor

This PR updates nibabel.volumeutils so that it recognises IndexedGzipFile objects as compressed files, and does not attempt to memory-map them.

Background at pauldmccarthy/indexed_gzip#38.

@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #925 into maint/3.1.x will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           maint/3.1.x     #925   +/-   ##
============================================
  Coverage        91.77%   91.77%           
============================================
  Files               97       97           
  Lines            12359    12360    +1     
  Branches          2177     2177           
============================================
+ Hits             11343    11344    +1     
  Misses             681      681           
  Partials           335      335           
Impacted Files Coverage Δ
nibabel/openers.py 95.09% <100.00%> (+0.04%) ⬆️
nibabel/volumeutils.py 84.52% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23de925...09e9368. Read the comment docs.

@effigies effigies changed the base branch from master to maint/3.1.x June 25, 2020 23:20
@effigies
Copy link
Member

@pauldmccarthy Thanks for this. It looks safe and bug-fixy. Would you mind rebasing on maint/3.1.x?

@pauldmccarthy pauldmccarthy force-pushed the rf/detect_igzip_as_compressed_file_type branch from 992f249 to 09e9368 Compare June 26, 2020 07:45
@pauldmccarthy
Copy link
Contributor Author

hey @effigies, no problem; I'm not sure if you meant to rebase against maint/3.1.x, as that would result in a PR containing all of the differences between master and maint/3.1.x. What I did instead was re-create the feature branch off maint/3.1.x, and then cherry pick the commit for this PR onto it. Let me know if that's what you wanted!

@effigies
Copy link
Member

Yup, this is exactly what I meant. Thanks!

@effigies effigies changed the title RF: Detect IndexedGzipFile as compressed file type FIX: Detect IndexedGzipFile as compressed file type Jun 26, 2020
@effigies effigies merged commit 42c5bd8 into nipy:maint/3.1.x Jun 26, 2020
@effigies effigies added this to the 3.1.1 milestone Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants