Skip to content

STY: Use triple double-quoted string in docstrings (PEP-257) #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2020

Conversation

jond01
Copy link
Contributor

@jond01 jond01 commented May 26, 2020

''' -> """

  • Some style in dicom/derivations

''' -> """
+ Some style in dicom/derivations
@jond01 jond01 mentioned this pull request May 26, 2020
5 tasks
@codecov
Copy link

codecov bot commented May 26, 2020

Codecov Report

Merging #918 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #918   +/-   ##
=======================================
  Coverage   91.73%   91.73%           
=======================================
  Files          97       97           
  Lines       12357    12357           
  Branches     2177     2177           
=======================================
  Hits        11336    11336           
  Misses        684      684           
  Partials      337      337           
Impacted Files Coverage Δ
nibabel/cifti2/parse_cifti2.py 83.86% <ø> (ø)
nibabel/data.py 86.99% <ø> (ø)
nibabel/dataobj_images.py 93.75% <ø> (ø)
nibabel/ecat.py 88.07% <ø> (ø)
nibabel/loadsave.py 92.59% <ø> (ø)
nibabel/minc1.py 90.64% <ø> (ø)
nibabel/minc2.py 89.87% <ø> (ø)
nibabel/nicom/csareader.py 87.40% <ø> (ø)
nibabel/nicom/dicomreaders.py 58.76% <ø> (ø)
nibabel/nicom/dicomwrappers.py 90.90% <ø> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 966a01e...29ad025. Read the comment docs.

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor correction that I'll make myself.

@effigies effigies changed the title RF: Use triple double-quoted string in docstrings STY: Use triple double-quoted string in docstrings (PEP-257) May 27, 2020
@effigies effigies merged commit b48fb17 into nipy:master May 27, 2020
@jond01 jond01 deleted the rf-docstrings branch May 27, 2020 16:13
@effigies effigies added this to the 3.2.0 milestone Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants