BF: be resilient to optional module non-ImportError exceptions upon import #618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mport ATM h5py is giving a grief while trying to work on a filesystem without utf-8 encoding support in filenames.
Codecov Report
@@ Coverage Diff @@
## master #618 +/- ##
=========================================
- Coverage 90.31% 90.3% -0.01%
=========================================
Files 87 87
Lines 10810 10813 +3
Branches 1793 1793
=========================================
+ Hits 9763 9765 +2
- Misses 718 719 +1
Partials 329 329
Continue to review full report at Codecov.
|
effigies
reviewed
Apr 12, 2018
| raise Exception( | ||
| "non ImportError could be thrown by some malfunctioning module " | ||
| "upon import, and optional_package should catch it too") | ||
| with mock.patch.object(builtins, '__import__', side_effect=raise_Exception): |
There was a problem hiding this comment.
In Python 3, builtins is __builtin__, and in Python 2 you're setting builtins = __builtin__. Could you just import __builtin__ and patch that here? I'm not sure what we're getting by adding this to py3k.
There was a problem hiding this comment.
In Python 3, builtins is __builtin__. I am confused with what you mean ;):
$> python3 -c 'import builtins'
$> python3 -c 'import __builtin__'
Traceback (most recent call last):
File "<string>", line 1, in <module>
ModuleNotFoundError: No module named '__builtin__'py3kis a module to establish the compatibility layer and feels intended to do so that code using it stays "python3" like. With this change then any code which needs to usebuiltinsmodule in either of pythons would do so with python3 naming. I didn't want to breed python 2-vs-3 code right here in the test
There was a problem hiding this comment.
Ah, perhaps this is an IPython thing.
In [1]: __builtin__
Out[1]: <module 'builtins' (built-in)>But:
$ python -c 'import builtins; print(builtins is __builtin__)'
Traceback (most recent call last):
File "<string>", line 1, in <module>
NameError: name '__builtin__' is not defined
|
ok - merging since no disagreement ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ATM h5py is giving a grief while trying to work on a filesystem without
utf-8 encoding support in filenames.