BF: Supports reading TRK (version 1) #512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #512 +/- ##
==========================================
+ Coverage 94.03% 94.04% +0.01%
==========================================
Files 166 166
Lines 21995 22017 +22
Branches 2343 2343
==========================================
+ Hits 20682 20706 +24
+ Misses 878 877 -1
+ Partials 435 434 -1
Continue to review full report at Codecov.
|
|
Thanks - have a look at : MarcCote#11 - seem reasonable to you? |
Also: slightly extend tests for version change.
MarcCote
force-pushed
the
bf_support_trk_v1
branch
from
a40e007 to
9ead3a8
Compare
|
I rebased, it should be all good. |
| import copy | ||
| import unittest | ||
| import numpy as np | ||
| from os.path import join as pjoin | ||
|
|
||
| from six import BytesIO | ||
| from nibabel.externals.six import BytesIO |
There was a problem hiding this comment.
Would you mind reverting this to from six import BytesIO? We're trying to remove use of the nibabel.externals.six module.
|
OK - looks good apart from the |
|
Thanks, in it goes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the streamlines API is not able to load TRK (version 1) since it misses the
vox_to_rasfield. This PR fixes that.With this PR, when loading a TRK (version 1), the
vox_to_rasfield is set so it contains all zeros. The rest of the code can already handle this case since in TRK (version 2) whenevervox_to_ras[3][3]is 0, it means the matrix is not recorded. The way it is curently handled is we assume the affine transformation is the identity matrix and we warn the user.In addition, this PR corrects some typos and changes a bit how we print the TRK header such that only the right amount of scalars and properties names are being displayed.