Skip to content

TST: make test shear matrix full rank #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2017

Conversation

matthew-brett
Copy link
Member

Matrix with shears was rank deficient, so small deviations in the SVD
output were making the tests fail - see:
http://nipy.bic.berkeley.edu/builders/nibabel-py2.7-debian-ppc/builds/106/steps/shell_6/logs/stdio

Make test matrix full rank to avoid test failures.

Matrix with shears was rank deficient, so small deviations in the SVD
output were making the tests fail - see:
http://nipy.bic.berkeley.edu/builders/nibabel-py2.7-debian-ppc/builds/106/steps/shell_6/logs/stdio

Make test matrix full rank to avoid test failures.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0004%) to 96.008% when pulling ab13027 on matthew-brett:sheared-rank-fix into b8017c9 on nipy:master.

@codecov-io
Copy link

codecov-io commented Feb 2, 2017

Codecov Report

Merging #510 into master will increase coverage by <.01%.

@@            Coverage Diff             @@
##           master     #510      +/-   ##
==========================================
+ Coverage   94.02%   94.03%   +<.01%     
==========================================
  Files         166      166              
  Lines       21992    21994       +2     
  Branches     2343     2343              
==========================================
+ Hits        20679    20681       +2     
  Misses        878      878              
  Partials      435      435
Impacted Files Coverage Δ
nibabel/tests/test_nifti1.py 98.32% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8017c9...ab13027. Read the comment docs.

@matthew-brett matthew-brett merged commit 7e08d25 into nipy:master Feb 11, 2017
@matthew-brett matthew-brett deleted the sheared-rank-fix branch February 11, 2017 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants