TST: add test for fix in PR 500 #502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Orientations calculation did not take into account what would happen with not-square matrices, 500 fixes this. These are some tests for fixed behavior.
Current coverage is 94.02% (diff: 100%)@@ master #502 diff @@
==========================================
Files 166 166
Lines 21832 21843 +11
Methods 0 0
Messages 0 0
Branches 2325 2325
==========================================
+ Hits 20527 20538 +11
Misses 875 875
Partials 430 430
|
effigies
reviewed
Jan 12, 2017
| mat, vec = to_matvec(def_aff) | ||
| aff_extra_col = np.zeros((4, 5)) | ||
| aff_extra_col[:3, :3] = mat | ||
| aff_extra_col[:3, -1] = vec |
There was a problem hiding this comment.
Is that supposed to be -1 with 5 columns? Or aff_extra_col[:3, 3]?
There was a problem hiding this comment.
(Assuming I understand what's going on...)
For clarity, maybe an easier way to do this would be to have:
base_affine = np.zeros((4,4))
base_affine [:3, :3] = mat
base_affine[:3, -1] = vec
aff_extra_col[:4, :4] = base_affine
aff_extra_row[:4, :4] = base_affineThere was a problem hiding this comment.
In both cases I was aiming for a 4th column / row with all zero, with the last column always being the translations, and non-zero. Is that what you thought?
There was a problem hiding this comment.
Ah, no, I misunderstood. Carry on, then.
Doesn't make any difference to calculations, but for the sake of a formally correct affine.
|
Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Orientations calculation did not take into account what would happen
with not-square matrices, 500 fixes this. These are some tests for
fixed behavior.