BF: boolean indexing now requires matching dimension #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 94.02% (diff: 100%)@@ master #500 diff @@
==========================================
Files 166 166
Lines 21832 21832
Methods 0 0
Messages 0 0
Branches 2327 2327
==========================================
Hits 20527 20527
Misses 875 875
Partials 430 430
|
effigies
approved these changes
Dec 23, 2016
|
Simple changes, I'm inclined to merge tomorrow, barring objections. Any comments? @matthew-brett? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #499
The tests are passing on my machine, so it doesn't seem to break anything (that is currently tested). Let's see what happen with the Numpy pre-release.