RF: Pull compression detection logic into a central private module #1212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1212 +/- ##
==========================================
+ Coverage 92.14% 92.16% +0.02%
==========================================
Files 97 98 +1
Lines 12334 12340 +6
Branches 2534 2535 +1
==========================================
+ Hits 11365 11373 +8
+ Misses 647 645 -2
Partials 322 322
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
No change to the API, and it fixes the failing CI. Happy to discuss alterations after the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is motivated by a change in
pyzstd, which exposes failures to read bad streams as customZstdErrors instead ofOSErrors. We had previously been depending on a conflation of these, asBZ2Filereturns a straightforwardOSErrorandGzipFilereturnsBadGzipFile, which subclasses fromOSError.Now there's no clear way of catching the various ways that reading a stream might fail without creating a collection of exceptions and adding to it when an interface that emits different errors is found.
Therefore, I've created a private
nibabel._compressionmodule. This housesopeners.COMPRESSED_FILE_LIKESand aliasesIndexedGzipFiletoGzipFilewhen it is unavailable, as well as provides a newCOMPRESSION_ERRORSexception type tuple that can be used inexceptstatements.Fixes #1209.