MNT: Replace versioneer with setuptools_scm #1171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
force-pushed
the
mnt/setuptools_scm
branch
from
71f9a63 to
365f3e8
Compare
Codecov ReportBase: 92.38% // Head: 92.36% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1171 +/- ##
==========================================
- Coverage 92.38% 92.36% -0.03%
==========================================
Files 98 97 -1
Lines 12257 12252 -5
Branches 2520 2520
==========================================
- Hits 11324 11316 -8
- Misses 612 614 +2
- Partials 321 322 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
effigies
force-pushed
the
mnt/setuptools_scm
branch
2 times, most recently
from
292a456 to
0fce94c
Compare
effigies
force-pushed
the
mnt/setuptools_scm
branch
2 times, most recently
from
fb98edf to
2663982
Compare
|
This is ready for review. |
Rename remaining setup.cfg to .flake8
These are now handled by setuptools_scm. Also, clarify the expected top-level packages in find
effigies
force-pushed
the
mnt/setuptools_scm
branch
from
9e955a6 to
e1f807c
Compare
effigies
force-pushed
the
mnt/setuptools_scm
branch
from
e1f807c to
cf564cf
Compare
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setuptools_scm now has git-archive support, is better maintained than versioneer (I say as the de facto maintainer of versioneer), can be used with other build backends than setuptools, and generally a smaller footprint in the package.
I'm interested to see if this passes all of our tests.