Skip to content

Remove throwing error when there no dictionary for an identifier #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 18, 2021
Merged

Remove throwing error when there no dictionary for an identifier #4

merged 2 commits into from
Jun 18, 2021

Conversation

nmint8m
Copy link
Contributor

@nmint8m nmint8m commented Jun 18, 2021

What happened 👀

In case the API returns with no dictionary data included, an exception will always be thrown. Example:

{
    "id": "some-id",
    "type": "some-type"
}

Insight 📝

Accept the resource can have data for only id and type.

@nmint8m nmint8m self-assigned this Jun 18, 2021
@nmint8m nmint8m requested review from suho, blyscuit and a team and removed request for blyscuit and suho June 18, 2021 06:35
@suho suho merged commit 7be29ab into main Jun 18, 2021
@suho suho deleted the feature/empty-dictionary branch June 18, 2021 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suho suho suho approved these changes

Assignees

@nmint8m nmint8m

Labels
type : feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmint8m @suho