Skip to content

Implement init for JSONAPIDecoder #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 17, 2021
Merged

Implement init for JSONAPIDecoder #3

merged 2 commits into from
Jun 17, 2021

Conversation

suho
Copy link
Member

@suho suho commented Jun 17, 2021

What happened 👀

We didn't public the init function of JSONAPIDecoder

Insight 📝

  • Public the init function
  • Remove unused file

Proof Of Work 📹

private let decoder: JSONEncoder

public init(decoder: JSONEncoder = JSONEncoder()) {
    self.decoder = decoder
    super.init()
}

@suho suho requested a review from a team June 17, 2021 06:41
@suho suho self-assigned this Jun 17, 2021
nmint8m
nmint8m approved these changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@nmint8m nmint8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suho suho merged commit d40a5a0 into main Jun 17, 2021
@suho suho deleted the feature/decoder-init branch June 17, 2021 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phongvhd93 phongvhd93 phongvhd93 approved these changes

@nmint8m nmint8m nmint8m approved these changes

Assignees

@suho suho

Labels
type : feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suho @phongvhd93 @nmint8m