Skip to content

[Feature] Create JSONMapper framework #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 17, 2021
Merged

[Feature] Create JSONMapper framework #1

merged 5 commits into from
Jun 17, 2021

Conversation

suho
Copy link
Member

@suho suho commented Jun 16, 2021

What happened 👀

Move JSONMapper from NimbleExtension to separate code

Insight 📝

I moved all files to this repo:

.
└── JSONMapper
    ├── Extensions
    │   ├── Encodable+Dictionary.swift
    │   └── Optional+Extras.swift
    ├── JSONAPIDecoder.swift
    └── Models
        ├── DataType.swift
        ├── JSON.swift
        ├── JSONAPIDecodingError.swift
        ├── JSONAPIError.swift
        ├── JSONAPIObject.swift
        ├── JSONAPIType.swift
        ├── Link.swift
        ├── Links.swift
        ├── Relationship.swift
        ├── Resource.swift
        └── ResourceIdentifier.swift

Proof Of Work 📹

Screen Shot 2021-06-16 at 11 28 06

@suho suho self-assigned this Jun 16, 2021
@suho suho changed the title Feature/move decoder from nimble extension [Feature] Create JSONMapper framework Jun 16, 2021
blyscuit
blyscuit approved these changes Jun 16, 2021
View reviewed changes
Copy link

@blyscuit blyscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rename this project to Swift-JSON-Mapper?

phongvhd93
phongvhd93 reviewed Jun 16, 2021
View reviewed changes
phongvhd93
phongvhd93 reviewed Jun 16, 2021
View reviewed changes
phongvhd93
phongvhd93 reviewed Jun 16, 2021
View reviewed changes
phongvhd93
phongvhd93 reviewed Jun 16, 2021
View reviewed changes
tamv263
tamv263 reviewed Jun 17, 2021
View reviewed changes
@suho suho requested review from tamv263 and phongvhd93 June 17, 2021 06:06
@suho suho merged commit e758d7d into main Jun 17, 2021
@suho suho deleted the feature/move-decoder-from-nimble-extension branch June 17, 2021 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blyscuit blyscuit blyscuit approved these changes

@phongvhd93 phongvhd93 phongvhd93 approved these changes

@edgarss edgarss Awaiting requested review from edgarss

@chiiida chiiida Awaiting requested review from chiiida

@markgravity markgravity Awaiting requested review from markgravity

@minhnimble minhnimble Awaiting requested review from minhnimble

@nmint8m nmint8m Awaiting requested review from nmint8m

@vnntsu vnntsu Awaiting requested review from vnntsu

@tamv263 tamv263 Awaiting requested review from tamv263

Assignees

@suho suho

Labels
type : feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@suho @blyscuit @phongvhd93 @tamv263