Skip to content

NH-4050 - Use Task.Run instead of BeginInvoke in Tests. #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 15, 2017
Merged

NH-4050 - Use Task.Run instead of BeginInvoke in Tests. #661

merged 2 commits into from
Jul 15, 2017

Conversation

ngbrown
Copy link
Contributor

@ngbrown ngbrown commented Jul 14, 2017

This is NH-4050.

Calling BeginInvoke() on delegates is obsolete and throws an exception in .NET Core:

System.PlatformNotSupportedException : Operation is not supported on this platform.

The same thing can be done with Task.Run(), running in a thread pool like BeginInvoke.

A prerequisite for #633

@fredericDelaporte fredericDelaporte merged commit 83603e0 into nhibernate:master Jul 15, 2017
@fredericDelaporte fredericDelaporte added this to the 5.0.0 milestone Jul 15, 2017
@ngbrown ngbrown deleted the NH-4050 branch July 16, 2017 16:04
@hazzik hazzik added the r: Fixed label Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredericDelaporte fredericDelaporte fredericDelaporte approved these changes

Assignees
No one assigned
Labels
r: Fixed t: Improvement
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ngbrown @fredericDelaporte @hazzik