NH-4023 - Passing session to type getter and setter

[fredericDelaporte]

NH-4023 for solving time issues for some databases.
NH-1851 MySql
NH-3078 Sybase Anywhere
NH-4017 Npgsql 3
NH-4024 ODBC

Maybe a replacement for #635 and #631.

But has a heavy impact on types, which may hinders UserType as shown in test project: it seems frequent to delegate the set/get of an user type to a NHibernate type. But with that change, that will require the session. And the user type will not have it.

[hazzik]

I think ISessionImplementor can be too much.
EDIT: gave it another thought and checked what Hibernate does.

[hazzik]

LGTM

[hazzik]

ODBC driver also requires TimeSpan

[hazzik]

On Hibernate side UserType has SharedSessionContractImplementor session (which is an equivalent of our ISessionImplementor) parameter in nullSafeGet and nullSafeSet methods, so I think we should do the same.

[fredericDelaporte]

On Hibernate side UserType has SharedSessionContractImplementor session

I have seen that Hibernate was not shy about passing that around, enforcing my decision for NullableType. But I have had not checked what is was for IUserType, thanks

I am ok with changing it too. Sure breaking change, but not doing it would be worst I think.

[fredericDelaporte]

ODBC driver also requires TimeSpan

Thanks. Should I update the tests result files by the way, for avoiding hiding those newly fixed cases? But it may enable some flaky test, if they have succeeded in the run from which I would take a new result file.

[hazzik]

Should I update the tests result files by the way, for avoiding hiding those newly fixed cases?

I think the goal shall be to have no red tests at all. So, we either need to fix them, or ignore them.

[hazzik]

👍