[WIP] - NH-2088 - Preliminary work required to generate async code #623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… factory method in order to ensure that the instance will always be fully initialized.
…nuget package System.Interactive.Async that will be used by the async Future methods
…ce async code generation
hazzik
commented
May 5, 2017
| @@ -42,7 +43,7 @@ public virtual void OnLock(LockEvent @event) | |||
| { | |||
| IEntityPersister persister = source.GetEntityPersister(@event.EntityName, entity); | |||
| object id = persister.GetIdentifier(entity); | |||
| if (!ForeignKeys.IsNotTransient(@event.EntityName, entity, false, source)) | |||
| if (ForeignKeys.IsTransientFast(@event.EntityName, entity, source).GetValueOrDefault()) | |||
There was a problem hiding this comment.
IsNotTransient does additional check on IsProxy and IsEntryFor. Both of these checks are performed above at lines L31 and L41-L42. So we can safely replace !IsNotTransient with IsTransient
|
Replaced by #677 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It does not compile because the code expects some methods to be already generated.