NH-3975 - Synchronize some features dialect support properties #591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mational metadata)
| @@ -14,7 +14,7 @@ protected override IList Mappings | |||
|
|
|||
| protected override bool AppliesTo(Dialect.Dialect dialect) | |||
| { | |||
| return dialect is MySQL5Dialect || dialect is MySQLDialect; | |||
| return dialect is MySQLDialect; | |||
There was a problem hiding this comment.
MySQL5Dialect inherits MySQLDialect, so I have just simplified this.
hazzik
reviewed
Apr 5, 2017
src/NHibernate/Dialect/DB2Dialect.cs
Outdated
|
|
||
| public override bool SupportsEmptyInList | ||
| { | ||
| get { return false; } |
There was a problem hiding this comment.
Can these one-line properties be written with expression syntax? I know that it'll make an inconsistency, but I'm ok with it.
There was a problem hiding this comment.
Agreed and done.
hazzik
approved these changes
Apr 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NH-3975 - Synchronize some features dialect support properties (Informational metadata).
A bunch of "Informational metadata" properties are defined on the base dialect class, and allow tests to ignore dialects which do not support the tested feature. Unfortunately, some of them are not up-to-date and causes such tests to fail instead of ignoring the dialect.
This PR aims at updating those properties according to their current value in Hibernate Java dialects implementation.
This has been done in a very conservative manner: each such property have been checked for not having any usage inside NHibernate (being purely informational), otherwise I have left them untouched. Some NHibernate dialect are overriding some of those properties while their Java counterpart do not, I have kept NHibernate overrides.
It would be probably nice to do a complete dialect sync, but this would have heavy transverse impacts. By example, the
SupportsTemporaryTableseems gone in Java, while in NHibernate it enables updates and deletes on classes having joined table (subclasses notably). This is why I have limited the scope of this Jira to purely informational properties.