Additional tests in StringTypeWithLengthFixture related to NH-3403 and NH-3036 #481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskarb
force-pushed
the
nh3403-param-length-test
branch
from
403be2a to
239287e
Compare
…lects. Most of these tests are now allowed to run on all SQL dialects, by more narrowly excluding only the cases that are really irrelevant. Also, querying with oversized parameter values are relevant also for the equality operator etc, so add tests for this. Related to NH-3403, NH-3036 and NH-2528.
Due to char set we may not be able to use 4000 characters on Oracle in the test environment. Try 2000 instead. Switch StringTypeWithLengthFixture over to mapping-by-code to facility different mapping on different dialects.
SQLite doesn't enforce specified string lengths.
…tion type. NhThrowsOnTooLong() and DbThrowsOnTooLong() were acquiring various dialect and driver exceptions (more would have been required than what was present). To avoid this, consider the prevention of the truncation/inserting the important bit, and make the test care less about which particular exception occur under which driver/dialect. Rename the test cases to reflect this.
…ird. Apparently we're supposed to add casts around the SQL parameters otherwise Firebird seems to grab the type from the other operand. But that is a separate issue.
… for oversized parameter.
…h should be the maximum for the TEXT type.
oskarb
force-pushed
the
nh3403-param-length-test
branch
from
239287e to
4e204ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to test on various dialects. Not necessarily intended for direct merging.