Skip to content

Ingres9 sequences #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Conversation

gamblen
Copy link

@gamblen gamblen commented Jul 21, 2015

Support for Sequence use within Ingres

@hazzik hazzik added this to the 4.1.0 milestone Sep 11, 2015
@oskarb
Copy link
Member

oskarb commented Nov 20, 2016

@oskarb
Copy link
Member

oskarb commented Nov 20, 2016

Closing this. I've submitted a cleaned version as PR #529.

@oskarb oskarb closed this Nov 20, 2016
@oskarb oskarb removed this from the 4.1.0 milestone Nov 20, 2016
@oskarb
Copy link
Member

oskarb commented Dec 4, 2016

@gamblen The cleaned up code is in PR #529, but it fails some tests. Please have a look at fixing that.

@gamblen
Copy link
Author

gamblen commented Dec 4, 2016

@oskarb I have got PR#529 and it builds ok. I cannot access the TeamCity details on why they are failing to build, but I cannot imagine how adding a couple of changes to the Ingres9 Dialect can make the builds fail for unrelated databases. I am unsure how to proceed.

@oskarb
Copy link
Member

oskarb commented Dec 4, 2016 via email

@gamblen
Copy link
Author

gamblen commented Dec 4, 2016

@oskarb Yes, there were plenty of failures, mostly all unable to connect to a MSSQL database. I am currently on a laptop with no DB's installed, so possibly cannot see the wood for the trees.. There is no steps in the ShowMenuBuild.bat that will setup for Ingres. Would that need to be done?

@oskarb
Copy link
Member

oskarb commented Dec 4, 2016

@gamblen Let's continue the discussion in #529.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants