NH-3474 - Fix support of GroupBy with constant keys #434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PleasantD
commented
Jun 24, 2015
PleasantD
commented
- Remove the GROUP BY clause entirely if all keys are constant
- Re-write the GROUP BY clause using only non-constant keys
|
@hazzik It would be very beneficial if this fix could be included in v4.1.0 |
| FlattenSubQuery(queryModel, subQueryExpression.QueryModel, groupBy); | ||
| RemoveCostantGroupByKeys(queryModel, groupBy).ForEach(groupByKeys.Add); |
There was a problem hiding this comment.
Can you please rewrite this to regular foreach?
| @@ -549,6 +549,46 @@ public void GroupByComputedValueInObjectArray() | |||
| Assert.AreEqual(830, orderGroups.Sum(g => g.Count)); | |||
| } | |||
|
|
|||
| [Test(Description = "NH-3474")] | |||
| public void GroupByConstant() | |||
There was a problem hiding this comment.
Generates
select
cast(count(*) as INT) as col_0_0_,
cast(sum(order0_.Freight) as DECIMAL(19,
5)) as col_1_0_
from
Orders order0_
|
Fixed the overcaching issue and fixed other comments. |
Merged
|
@PleasantD can you please squash the PR and rebase on master? |
* Remove the GROUP BY clause entirely if all keys are constant * Re-write the GROUP BY clause using only non-constant keys * Adjust the ExpressionKeyVisitor so that constants in GroupBy are not replaced with parameter * Fix ExpressionKeyVisitor handling of constant arrays to show initialization values
|
I've added some more tests and merged. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.