NH 3797 #432
Merged
NH 3797 #432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Fixed the tabification. Please let me know how I can help expedite the next release. |
…lause rewriting - Added test cases - Added the GroupByKeys expression list into the VisitorParameters class - Created an extension method to simplify the extraction of group by key expressions
hazzik
added a commit
that referenced
this pull request
Jun 23, 2015
NH-3797 - Use group by keys as first class HqlCandidates for select clause rewriting
PleasantD
added a commit
to PleasantD/nhibernate-core
that referenced
this pull request
Jul 7, 2015
…lauses - Conditional statements are now generated in SQL for select clauses - Case statements in the select clause don't generate unexpected or implicit joins for the test expression - Combined the logic from SelectJoinDetector and ResultOperatorAndOrderByJoinDetector, also handles case statement join logic - Removed most of the changes from NH-3797 (pull request nhibernate#432) as they are now unnecessary because the select clause now does the right thing
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://nhibernate.jira.com/browse/NH-3797
Modify the QueryModelVisitor to treat group by keys as first-class HQL candidates for select clause rewriting.