Skip to content

NH-3704 - Allow Setting Dynamic Component Templates From Dictionary #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

NH-3704 - Allow Setting Dynamic Component Templates From Dictionary #341

wants to merge 3 commits into from

Conversation

rjperes
Copy link
Member

@rjperes rjperes commented Sep 22, 2014 •
edited by fredericDelaporte
Loading

#913 (NH-3704)
With unit tests

@hazzik hazzik added this to the 5.0.0 milestone Sep 26, 2014
@hazzik
Copy link
Member

hazzik commented Nov 24, 2014

@rjperes can you please remove references to SharpTestEx?

@rjperes
Copy link
Member Author

rjperes commented Nov 24, 2014

OK.

hazzik
hazzik reviewed Nov 24, 2014
View reviewed changes
src/NHibernate/Mapping/ByCode/Impl/CustomizersImpl/DynamicComponentCustomizer.cs
explicitDeclarationsHolder.AddAsDynamicComponent(propertyPath.LocalMember, componentType);
}

private System.Type CreateType(IDictionary<string, System.Type> properties)

This comment was marked as spam.

Sign in to view

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand your aspiration to implement changes with fewer possible code changes, but I want to have this properly implemented

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, but try another way, it's not easy.

@hazzik hazzik changed the title NH-3704 NH-3704 - Allow Setting Dynamic Component Templates From Dictionary Dec 2, 2014
@hazzik
Copy link
Member

hazzik commented Apr 26, 2017

MappingByCode is heavily dependent on MemberInfo. So, it might be that this hack is actually justified.

@hazzik hazzik modified the milestones: 5.0, 5.1 Sep 1, 2017
@nhibernate-bot nhibernate-bot mentioned this pull request Oct 12, 2017
Closed
@hazzik hazzik modified the milestones: 5.1, 6.0 Dec 23, 2017
@fredericDelaporte
Copy link
Member

fredericDelaporte commented Dec 20, 2018 •
edited
Loading

@rjperes's PRs have been orphaned by the deletion of their repository, which causes them to be unpractical to work with.

They can still be retrieved with, for example:

git fetch upstream pull/341/head:pr-341

This assumes upstream is the nhibernate/nhibernate-core remote. The first 341 has to be the PR number. pr-341 can be whatever you like, it is the name for a local branch on which to get the PR.

Pushing to the PR seems not possible. I have tried:

git push -f -u upstream pr-341:refs/pull/341/head

And got:

 ! [remote rejected]     pr-341 -> refs/pull/341/head (deny updating a hidden ref)

So for working with these PRs, I think we will have to reopen new ones replacing them.

@fredericDelaporte fredericDelaporte mentioned this pull request Dec 20, 2018
Merged
@fredericDelaporte
Copy link
Member

Replaced by #1941.

@fredericDelaporte fredericDelaporte removed this from the 6.0 milestone Dec 20, 2018
@fredericDelaporte fredericDelaporte mentioned this pull request Feb 13, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs work r: Replaced
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rjperes @hazzik @fredericDelaporte