NH-3606 - A method to create a child stateless session #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskarb
changed the title
- More unit tests - Logic moved from extension method to SessionImpl - Proper disposing of child stateless session by parent session - Added extension method AsStateless (NH-3231)
|
Done. |
|
Yep, much nicer. Thanks |
hazzik
changed the title
hazzik
changed the title
|
May I rebase this PR? |
|
OK with me. |
hazzik
reviewed
Apr 5, 2017
| @@ -13,6 +13,14 @@ namespace NHibernate.Linq | |||
| { | |||
| public static class LinqExtensionMethods | |||
| { | |||
| public static IQueryable<T> AsStateless<T>(this IQueryable<T> query) | |||
There was a problem hiding this comment.
I don't like this extensions. It needs to be implemented as a separate feature.
hazzik
requested changes
Apr 5, 2017
|
@fredericDelaporte is this still required? |
|
This NH-3606 feature is not covered by the new "session sharing some parts of another" way of opening sessions, having replaced child sessions. Hibernate Java does not have it either, so having realigned on Hibernate for session opening has not brought this feature in. I guess it could still be useful and added to current master, but this would require another PR. (Or rewriting most changes of this one.) |
|
Replaced by #1520 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#910, https://nhibernate.jira.com/browse/NH-3606