Skip to content

Add support for nested non aggregating group by operators #3087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 10, 2022
Merged

Conversation

hazzik
Copy link
Member

@hazzik hazzik commented Jul 29, 2022

Fixes #3076

hazzik added 3 commits July 29, 2022 13:04
Next step would be to change ProcessNonAggregatingGroupBy to correctly detect source expression for second result operator
hazzik and others added 5 commits July 29, 2022 16:54
Resolved issues in src/NHibernate/Linq/GroupBy/NonAggregatingGroupByRewriter.cs via DeepSource Autofix
Co-authored-by: Frédéric Delaporte <12201973+fredericDelaporte@users.noreply.github.com>
@hazzik
Copy link
Member Author

hazzik commented Aug 7, 2022

@hazzik dismissed @fredericDelaporte’s stale review

@fredericDelaporte could you please tick again?

@hazzik hazzik added this to the next minor milestone Aug 10, 2022
@hazzik hazzik merged commit 267e226 into master Aug 10, 2022
@hazzik hazzik deleted the gh-3076 branch August 10, 2022 08:13
@ShyamVeerapallyTR
Copy link

I tried to look for this fix in release notes of 5.3.13 and 5.3.14 but couldn't find #3087 . Can you please let me know whether this has been released?

@hazzik
Copy link
Member Author

hazzik commented Nov 4, 2022 via email

@ShyamVeerapallyTR
Copy link

It is in unreleased 5.4 versionMessage ID: @.***>

Thanks @hazzik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested group by results in "A recognition error occured"
3 participants