Fix QueryStatistics.ExecutionAvgTime calculation #2968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hazzik
changed the title
hazzik
previously approved these changes
Jan 10, 2022
|
Seems async regen is needed for tests |
|
@bahusoid thanks. Done. |
hazzik
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QueryStatistics.ExecutionAvgTime was incorrectly calculated.
Assuming a query first took 10ms and then 30ms, the average between both should be 20ms.
However, the old implementation was newAvgTime = (oldAvgTime * n + curTime) / n which in the provided example would result in (10*2+30)/2 = 50/2 = 25.
As the old average time was calculated on (n-1) samples the first instance of n should be n-1 instead, which correctly results in (10*(2-1)+30)/2 = 40/2 = 20.