Replace Travis CI with GitHub Actions #2812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahusoid
commented
Jun 6, 2021
| CONNECTION_STRING: "DataSource=localhost;Database=nhibernate;User=SYSDBA;Password=nhibernate;charset=utf8;" | ||
| - DB: MySQL | ||
| CONNECTION_STRING: "Server=localhost;Uid=root;Password=nhibernate;Database=nhibernate;Old Guids=True;" | ||
| ALLOW_FAILURE: true |
There was a problem hiding this comment.
This line should be removed when merged to master.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@hazzik Regarding adding windows in matrix. See https://github.com/bahusoid/nhibernate-core/blob/ghawithWin/.github/workflows/NetCoreTests.yml#L10-L11 But containers don't work on windows: https://github.com/bahusoid/nhibernate-core/actions/runs/913556186 |
|
Maybe we can use services instead of docker |
|
Ok, it seems services also require linux. |
If I got it right "service" is just another way to configure docker container in Github Action. Only it doesn't support conditional configurations for jobs (like install only Firebird for this job) |
hazzik
reviewed
Jun 7, 2021
Sorry to see you go. You've been a good friend. RIP.
hazzik
approved these changes
Jun 8, 2021
Merged
bahusoid
added a commit
to bahusoid/nhibernate-core
that referenced
this pull request
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As replacement for Travis.
Pretty much the same experience except you currently can restart only all jobs (not possible to restart only failed jobs). And each job is displayed as separate check on github UI.
See results:
https://github.com/bahusoid/nhibernate-core/actions/runs/911887765