Fix join on interface in Linq/hql #2810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahusoid
commented
Jun 3, 2021
| @@ -570,8 +570,9 @@ public bool ContainsBaseMember(JoinClause joinClause) | |||
| { | |||
| // Visit the join inner key only for entities that have subclasses | |||
| if (joinClause.InnerSequence is ConstantExpression constantNode && | |||
| constantNode.Value is IEntityNameProvider entityNameProvider && | |||
| !_sessionFactory.GetEntityPersister(entityNameProvider.EntityName).EntityMetamodel.HasSubclasses) | |||
| constantNode.Value is IEntityNameProvider && | |||
There was a problem hiding this comment.
Changes in this file should be ignored when merged to master (5.3 specific fix)
fredericDelaporte
approved these changes
Jun 6, 2021
Merged
This was referenced Jul 13, 2021
bahusoid
added a commit
to bahusoid/nhibernate-core
that referenced
this pull request
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2805
Regression from #2327 (by using hql entity join in Linq instead of implicit joins)