NH-3630 - Add bitwise operation support for dialects using internal/external functions

[amroel]

https://nhibernate.jira.com/browse/NH-3630
Changes to SqlGenerator and Dialect to allow injection of vendor specific bitwise functions
+
Bitwise functions for firebird

[oskarb]

In HQL you can write anyRandomFunctionName(x,y) and if the HQL parser doesn't recognize it, the call will be copied directly into the SQL. Have you verified that no supported database directly supports the band, bor, bxor and bnot as function names? If any does, this may cause a regression.

[amroel]

No, it won't. It will get passed to sql just as did before.
The Intention is that " & ", " | ", " ^ " and " ~ " will be identified by the SQLGenerator class as Bitwise operations.
For the SqlGenerator to call the proper function on the dialect it searches internally for functions named band, bor, bxor and bnot.
Hence if the HQL code does directly call band, bor etc. they won't be recognized at all and thus will get passed directly to SQL.

[hazzik]

@amroel can you please clean-up this pull request (rebase on top of master) and add some other dialects?

[hazzik]

Also, I would like have grammar unchanged and instead change linq to hql generator to use functions instead of operators (like this has been done with concat)

[amroel]

@hazzik What is the reasoning behind leaving the grammer unchanged?
Your proposal will work for Linq but would still fail for HQL would'nt it?

[hazzik]

I think it is better to be explicit rather than make some tricky changes

[amroel]

Sorry @hazzik, but I still don't get it :)
Changing Linq would still leave existing HQL tests with Bitwise operations failing!
Or am I missing something?

[hazzik]

@amroel can you please rebase this on top of master? This will require grammar regeneration as well.

[amroel]

@hazzik Done.