-
Notifications
You must be signed in to change notification settings - Fork 934
Make sure dbcommand is disposed #2656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure dbcommand is disposed #2656
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have qualified it as just a minor improvement instead of a major bug because in most cases with db commands, this disposal lack will not cause an unmanaged leak and will not prevent the command from being garbage collected.
If I am wrong, this fix should then be re-tagged, but also should then target 5.3.x and likely be back-ported down to the introduction of the generic batching batcher.
Agreed, I think it's minor as well, no unmanaged leak when Still good to have it fixed (as "minor", yes). |
....on the other hand it might cause an unmanged leak if an other |
@fredericDelaporte maybe for 5.3.6? |
Why not. |
b63d43b
to
2471c71
Compare
Changing the base did not went well, so I have done it manually with a forced push. |
DbCommands created in GenericBatchingBatcher aren't disposed.