WIP Fix nullable entity comparison with null #2612
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahusoid
changed the title
bahusoid
commented
Nov 23, 2020
| joinIsNeeded = comparisonWithNullableEntity = true; | ||
|
|
||
| //TODO: Fix this hack. Ideally we should always left join here. Skip left join for nullable entity if query contains implicit joins. We currently don't support left joins for such queries (see OneToOneCompositeQueryCompareWithJoinOrIsNull) | ||
| var fromJoins = ASTUtil.CollectChildren<FromElement>(Walker.CurrentFromClause, x => x is FromElement fe && !fe.IsImplied && fe.Type == HqlSqlWalker.FROM_FRAGMENT); |
There was a problem hiding this comment.
So hacky... :( Not even sure it handles all the cases..
|
Is this fixing a regression, or fixing an additional case of an old issue which was only partially fixed? If that is the later, it would be better to target master. |
|
It's fixing additional case... And I don't like this fix at all.. So will close it now. Needs some thinking when I have time.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently fix made in #2081 wasn't enough as implicit joins were generated for comparisons like
where entity.OneToOne is null. It should be left join instead...Fixes #2611