Default value for CancellationToken in IQueryBatch.GetResultAsync #2571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These files are auto-generated. This would need to be done with AsyncGenerator.yml |
|
Thanks @hazzik |
fredericDelaporte
approved these changes
Sep 28, 2020
fredericDelaporte
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to propose default value of second parameter in function
IQueryBatch.GetResultAsyncto bedefault(CancellationToken). This would be consistent with the rest of async functionsSingleOrDefaultAsync, ListAsyncandRowCountAsync, where in each and every case this is the default value for cancellation.To my best knowledge this should be nonbreaking change. Due to triviality I don't think any tests are required here.