Skip to content

Support internal entity classes by proxy factory #2568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 28, 2020
Merged

Support internal entity classes by proxy factory #2568

merged 2 commits into from
Sep 28, 2020

Conversation

bahusoid
Copy link
Member

We do support proxy for internal interfaces since #1814
So not supporting internal classes looks like omission to me

@fredericDelaporte
Copy link
Member

Do you mean it was supported prior to #1814? It would be a regression then.

@bahusoid
Copy link
Member Author

Do you mean it it was supported prior to #1814

No. Why? #1814 added support only for internal interfaces. This one adds support for internal base class.

@hazzik hazzik changed the title Support internal entity classes Support internal entity classes by proxy factory Sep 28, 2020
@hazzik hazzik merged commit 9255435 into nhibernate:master Sep 28, 2020
@hazzik hazzik added this to the next minor milestone Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hazzik hazzik hazzik approved these changes

Assignees
No one assigned
Labels
c: ByteCode providers p: Lowest r: Fixed t: Improvement
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@bahusoid @fredericDelaporte @hazzik