Skip to content

Cast operation fails when an enum is mapped as an AnsiString #2499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 30, 2020
Merged

Cast operation fails when an enum is mapped as an AnsiString #2499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
73fc3ad
Modified Linq Enum unit tests to test alternate mappings
gliljas Aug 26, 2020
c0bf3c6
Check if enum is mapped as any kind of string
gliljas Aug 26, 2020
5642743
Make DbTypeExtensions internal
hazzik Aug 26, 2020
5a90a74
Async regen
hazzik Aug 26, 2020
b82d1e1
Modified tests
gliljas Aug 27, 2020
20d453a
Revert "Modified tests"
gliljas Aug 28, 2020
bf5bb34
Revert test changes. Added formula.
gliljas Aug 28, 2020
1764a68
Adjust test to make it green
bahusoid Aug 29, 2020
7062def
Fix tests for Firebird and MySql
bahusoid Aug 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
188 changes: 133 additions & 55 deletions src/NHibernate.Test/Async/Linq/EnumTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,103 +8,181 @@
//------------------------------------------------------------------------------


using System;
using System.Linq;
using NHibernate.DomainModel.Northwind.Entities;
using NHibernate.Cfg.MappingSchema;
using NHibernate.Mapping.ByCode;
using NHibernate.SqlTypes;
using NHibernate.Type;
using NUnit.Framework;
using NHibernate.Linq;

namespace NHibernate.Test.Linq
{
using System.Threading.Tasks;
using System.Threading;
[TestFixture]
public class EnumTestsAsync : LinqTestCase
[TestFixture(typeof(EnumType<TestEnum>), "0")]
[TestFixture(typeof(EnumStringType<TestEnum>), "'Unspecified'")]
[TestFixture(typeof(EnumAnsiStringType<TestEnum>), "'Unspecified'")]
public class EnumTestsAsync : TestCaseMappingByCode
{
[Test]
public async Task CanQueryOnEnumStoredAsInt32_High_1Async()
private IType _enumType;
private string _unspecifiedValue;

public EnumTestsAsync(System.Type enumType, string unspecifiedValue)
{
await (CanQueryOnEnumStoredAsInt32Async(EnumStoredAsInt32.High, 1));
_enumType = (IType) Activator.CreateInstance(enumType);
_unspecifiedValue = unspecifiedValue;
}

[Test]
public async Task CanQueryOnEnumStoredAsInt32_Unspecified_2Async()
protected override HbmMapping GetMappings()
{
await (CanQueryOnEnumStoredAsInt32Async(EnumStoredAsInt32.Unspecified, 2));
var mapper = new ModelMapper();
mapper.Class<EnumEntity>(
rc =>
{
rc.Table("EnumEntity");
rc.Id(x => x.Id, m => m.Generator(Generators.Guid));
rc.Property(x => x.Name);
rc.Property(x => x.Enum1, m => m.Type(_enumType));
rc.Property(x => x.NullableEnum1, m =>
{
m.Type(_enumType);
m.Formula($"(case when Enum1 = {_unspecifiedValue} then null else Enum1 end)");
});
rc.ManyToOne(x => x.Other, m => m.Cascade(Mapping.ByCode.Cascade.All));
});

return mapper.CompileMappingForAllExplicitlyAddedEntities();
}

public async Task CanQueryOnEnumStoredAsInt32Async(EnumStoredAsInt32 type, int expectedCount, CancellationToken cancellationToken = default(CancellationToken))
protected override void OnSetUp()
{
var query = await ((from user in db.Users
where user.Enum2 == type
select user).ToListAsync(cancellationToken));
base.OnSetUp();
using (var session = OpenSession())
using (var trans = session.BeginTransaction())
{
session.Save(new EnumEntity { Enum1 = TestEnum.Unspecified });
session.Save(new EnumEntity { Enum1 = TestEnum.Small });
session.Save(new EnumEntity { Enum1 = TestEnum.Small });
session.Save(new EnumEntity { Enum1 = TestEnum.Medium });
session.Save(new EnumEntity { Enum1 = TestEnum.Medium });
session.Save(new EnumEntity { Enum1 = TestEnum.Medium });
session.Save(new EnumEntity { Enum1 = TestEnum.Large });
session.Save(new EnumEntity { Enum1 = TestEnum.Large });
session.Save(new EnumEntity { Enum1 = TestEnum.Large });
session.Save(new EnumEntity { Enum1 = TestEnum.Large });
trans.Commit();
}
}

protected override void OnTearDown()
{
using (var session = OpenSession())
using (var transaction = session.BeginTransaction())
{
session.Delete("from System.Object");

session.Flush();
transaction.Commit();
}
}

Assert.AreEqual(expectedCount, query.Count);
[Test]
public async Task CanQueryOnEnum_Large_4Async()
{
await (CanQueryOnEnumAsync(TestEnum.Large, 4));
}

[Test]
public async Task CanQueryOnEnum_Medium_3Async()
{
await (CanQueryOnEnumAsync(TestEnum.Medium, 3));
}

[Test]
public async Task CanQueryOnEnumStoredAsString_Meduim_2Async()
public async Task CanQueryOnEnum_Small_2Async()
{
await (CanQueryOnEnumStoredAsStringAsync(EnumStoredAsString.Medium, 2));
await (CanQueryOnEnumAsync(TestEnum.Small, 2));
}

[Test]
public async Task CanQueryOnEnumStoredAsString_Small_1Async()
public async Task CanQueryOnEnum_Unspecified_1Async()
{
await (CanQueryOnEnumStoredAsStringAsync(EnumStoredAsString.Small, 1));
await (CanQueryOnEnumAsync(TestEnum.Unspecified, 1));
}

public async Task CanQueryOnEnumStoredAsStringAsync(EnumStoredAsString type, int expectedCount, CancellationToken cancellationToken = default(CancellationToken))
private async Task CanQueryOnEnumAsync(TestEnum type, int expectedCount, CancellationToken cancellationToken = default(CancellationToken))
{
var query = await ((from user in db.Users
where user.Enum1 == type
select user).ToListAsync(cancellationToken));
using (var session = OpenSession())
using (var trans = session.BeginTransaction())
{
var query = await (session.Query<EnumEntity>().Where(x => x.Enum1 == type).ToListAsync(cancellationToken));

Assert.AreEqual(expectedCount, query.Count);
Assert.AreEqual(expectedCount, query.Count);
}
}

[Test]
public async Task CanQueryWithContainsOnEnumStoredAsString_Small_1Async()
public async Task CanQueryWithContainsOnTestEnum_Small_1Async()
{
var values = new[] { EnumStoredAsString.Small, EnumStoredAsString.Medium };
var query = await (db.Users.Where(x => values.Contains(x.Enum1)).ToListAsync());
Assert.AreEqual(3, query.Count);
var values = new[] { TestEnum.Small, TestEnum.Medium };
using (var session = OpenSession())
using (var trans = session.BeginTransaction())
{
var query = await (session.Query<EnumEntity>().Where(x => values.Contains(x.Enum1)).ToListAsync());

Assert.AreEqual(5, query.Count);
}
}

[Test]
public async Task ConditionalNavigationPropertyAsync()
{
EnumStoredAsString? type = null;
await (db.Users.Where(o => o.Enum1 == EnumStoredAsString.Large).ToListAsync());
await (db.Users.Where(o => EnumStoredAsString.Large != o.Enum1).ToListAsync());
await (db.Users.Where(o => (o.NullableEnum1 ?? EnumStoredAsString.Large) == EnumStoredAsString.Medium).ToListAsync());
await (db.Users.Where(o => ((o.NullableEnum1 ?? type) ?? o.Enum1) == EnumStoredAsString.Medium).ToListAsync());

await (db.Users.Where(o => (o.NullableEnum1.HasValue ? o.Enum1 : EnumStoredAsString.Unspecified) == EnumStoredAsString.Medium).ToListAsync());
await (db.Users.Where(o => (o.Enum1 != EnumStoredAsString.Large
? (o.NullableEnum1.HasValue ? o.Enum1 : EnumStoredAsString.Unspecified)
: EnumStoredAsString.Small) == EnumStoredAsString.Medium).ToListAsync());

await (db.Users.Where(o => (o.Enum1 == EnumStoredAsString.Large ? o.Role : o.Role).Name == "test").ToListAsync());
TestEnum? type = null;
using (var session = OpenSession())
using (var trans = session.BeginTransaction())
{
var entities = session.Query<EnumEntity>();
await (entities.Where(o => o.Enum1 == TestEnum.Large).ToListAsync());
await (entities.Where(o => TestEnum.Large != o.Enum1).ToListAsync());
await (entities.Where(o => (o.NullableEnum1 ?? TestEnum.Large) == TestEnum.Medium).ToListAsync());
await (entities.Where(o => ((o.NullableEnum1 ?? type) ?? o.Enum1) == TestEnum.Medium).ToListAsync());

await (entities.Where(o => (o.NullableEnum1.HasValue ? o.Enum1 : TestEnum.Unspecified) == TestEnum.Medium).ToListAsync());
await (entities.Where(o => (o.Enum1 != TestEnum.Large
? (o.NullableEnum1.HasValue ? o.Enum1 : TestEnum.Unspecified)
: TestEnum.Small) == TestEnum.Medium).ToListAsync());

await (entities.Where(o => (o.Enum1 == TestEnum.Large ? o.Other : o.Other).Name == "test").ToListAsync());
}
}

[Test]
public async Task CanQueryComplexExpressionOnEnumStoredAsStringAsync()
public async Task CanQueryComplexExpressionOnTestEnumAsync()
{
var type = EnumStoredAsString.Unspecified;
var query = await ((from user in db.Users
where (user.NullableEnum1 == EnumStoredAsString.Large
? EnumStoredAsString.Medium
: user.NullableEnum1 ?? user.Enum1
) == type
select new
{
user,
simple = user.Enum1,
condition = user.Enum1 == EnumStoredAsString.Large ? EnumStoredAsString.Medium : user.Enum1,
coalesce = user.NullableEnum1 ?? EnumStoredAsString.Medium
}).ToListAsync());

Assert.That(query.Count, Is.EqualTo(0));
//TODO: Fix issue on SQLite with type set to TestEnum.Unspecified
TestEnum? type = null;
using (var session = OpenSession())
using (var trans = session.BeginTransaction())
{
var entities = session.Query<EnumEntity>();

var query = await ((from user in entities
where (user.NullableEnum1 == TestEnum.Large
? TestEnum.Medium
: user.NullableEnum1 ?? user.Enum1
) == type
select new
{
user,
simple = user.Enum1,
condition = user.Enum1 == TestEnum.Large ? TestEnum.Medium : user.Enum1,
coalesce = user.NullableEnum1 ?? TestEnum.Medium
}).ToListAsync());

Assert.That(query.Count, Is.EqualTo(0));
}
}
}
}
Loading