Skip to content

Release 5.3.1 #2450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2020
Merged

Release 5.3.1 #2450

merged 1 commit into from
Jul 26, 2020

Conversation

fredericDelaporte
Copy link
Member

@fredericDelaporte fredericDelaporte commented Jul 24, 2020

In case it is wished to release these 5.3.1 fixes soon, here is the the release PR.

@fredericDelaporte fredericDelaporte marked this pull request as ready for review July 25, 2020 18:11
@hazzik
Copy link
Member

hazzik commented Jul 26, 2020

Should we release today?

@fredericDelaporte
Copy link
Member Author

fredericDelaporte commented Jul 26, 2020

We could wait in case there are more regressions to fix, but it could also hinder detecting those other regressions due to failing before with the fixed ones, unless using the MyGet dev build.

So I am agree with releasing it today.
I will do this in 2 hours I think, unless in the mean time someone asks for waiting for some reasons.

@fredericDelaporte fredericDelaporte merged commit 2011a77 into nhibernate:5.3.x Jul 26, 2020
@fredericDelaporte fredericDelaporte deleted the 5.3.1 branch July 26, 2020 17:53
@fredericDelaporte
Copy link
Member Author

By the way, the release announcements on the nhuser group are not yet approved. It seems I am administrator only of the nhdevelopement group, and so someone else has to approve my announcements on nhuser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants